From 671cac07b35448820e4aabbfcb2c09ba6fd5db37 Mon Sep 17 00:00:00 2001 From: Wim Velzeboer Date: Mon, 11 Sep 2023 17:16:45 +0100 Subject: [PATCH 1/3] Remove Sharing Mode from Dynamic Application Factories Sharing mode is no longer required as SOQL queries can now run in USER_MODE or SYSTEM_MODE. --- .../fields/SharingMode__c.field-meta.xml | 36 ------------------- 1 file changed, 36 deletions(-) delete mode 100644 sfdx-source/apex-extensions/main/application/dynamic/objects/fflib_AppBinding__mdt/fields/SharingMode__c.field-meta.xml diff --git a/sfdx-source/apex-extensions/main/application/dynamic/objects/fflib_AppBinding__mdt/fields/SharingMode__c.field-meta.xml b/sfdx-source/apex-extensions/main/application/dynamic/objects/fflib_AppBinding__mdt/fields/SharingMode__c.field-meta.xml deleted file mode 100644 index f63e784..0000000 --- a/sfdx-source/apex-extensions/main/application/dynamic/objects/fflib_AppBinding__mdt/fields/SharingMode__c.field-meta.xml +++ /dev/null @@ -1,36 +0,0 @@ - - - SharingMode__c - "With Sharing" - false - DeveloperControlled - - true - Picklist - - true - - false - - With Sharing - true - - - - Without Sharing - false - - - - Inherited Sharing - false - - - - None - false - - - - - From 4390f83aefc379d680766166ebe57c9af49212ab Mon Sep 17 00:00:00 2001 From: Wim Velzeboer Date: Mon, 11 Sep 2023 17:18:53 +0100 Subject: [PATCH 2/3] Remove Sharing Mode from Dynamic Application Factories Sharing mode is no longer required as SOQL queries can now run in USER_MODE or SYSTEM_MODE. --- .../classes/fflib_ClassicSelectorFactory.cls | 3 ++- .../dynamic/classes/fflib_AppBinding.cls | 26 ------------------- .../fflib_AppBindingMetaDataModule.cls | 25 ------------------ .../classes/fflib_AppBindingResolver.cls | 6 ----- .../classes/fflib_AppBindingsSelector.cls | 1 - .../classes/fflib_DynamicSelectorFactory.cls | 6 ----- .../classes/fflib_DynamicServiceFactory.cls | 6 ----- .../classes/interfaces/fflib_IAppBinding.cls | 18 ------------- ...inding__mdt-Binding Layout.layout-meta.xml | 4 --- .../fflib_DynamicDomainFactoryTest.cls | 6 ++--- .../fflib_DynamicSelectorFactoryTest.cls | 6 ++--- .../fflib_DynamicServiceFactoryTest.cls | 5 ---- 12 files changed, 6 insertions(+), 106 deletions(-) diff --git a/sfdx-source/apex-extensions/main/application/classic/classes/fflib_ClassicSelectorFactory.cls b/sfdx-source/apex-extensions/main/application/classic/classes/fflib_ClassicSelectorFactory.cls index 6b2ed96..0f6cd20 100644 --- a/sfdx-source/apex-extensions/main/application/classic/classes/fflib_ClassicSelectorFactory.cls +++ b/sfdx-source/apex-extensions/main/application/classic/classes/fflib_ClassicSelectorFactory.cls @@ -59,7 +59,8 @@ public virtual class fflib_ClassicSelectorFactory * @param sObjectType The SObjectType of the Ids * * @return The queried records - * @exception fflib_Application.DeveloperException is thrown if the Ids set is empty + * + * @throws fflib_Application.DeveloperException is thrown if the Ids set is empty */ public virtual List selectById(Set recordIds, SObjectType sObjectType) { diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBinding.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBinding.cls index e88ae6c..dddbcf6 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBinding.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBinding.cls @@ -38,7 +38,6 @@ public virtual class fflib_AppBinding protected System.Type interfaceType { get; set; } protected String namespacePrefix { get; set; } protected String packageName { get; set; } - protected fflib_SharingMode sharingMode { get; set; } public Integer compareTo(Object compareTo) { @@ -106,16 +105,6 @@ public virtual class fflib_AppBinding return this.bindingSequence; } - /** - * @return Returns an enum value fflib_SharingMode that defines the type of sharing used in the implementation class - * - * @see fflib_SharingMode - */ - public virtual fflib_SharingMode getSharingMode() - { - return this.sharingMode; - } - /** * Creates a new instance of the implementation for this binding. * @@ -224,19 +213,4 @@ public virtual class fflib_AppBinding this.bindingSequence = sequence; return this; } - - /** - * Sets an enum value fflib_SharingMode that defines the type of sharing used in the implementation class - * - * @param sharingMode A enum value of fflib_SharingMode representing the sharing mode - * - * @return An instance of itself to enable method chaining - * - * @see fflib_SharingMode - */ - public virtual fflib_IAppBinding setSharingMode(fflib_SharingMode sharingMode) - { - this.sharingMode = sharingMode; - return this; - } } \ No newline at end of file diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingMetaDataModule.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingMetaDataModule.cls index ddb522e..601accb 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingMetaDataModule.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingMetaDataModule.cls @@ -45,7 +45,6 @@ public with sharing class fflib_AppBindingMetaDataModule .setNamespacePrefix(binding.NamespacePrefix) .setPackageName(binding.ApplicationPackage__r.DeveloperName) .setSequence(binding.BindingSequence__c) - .setSharingMode(getSharingModeFromString(binding.SharingMode__c)) ); } } @@ -94,30 +93,6 @@ public with sharing class fflib_AppBindingMetaDataModule return bindingTypeByStrings.get(binding.Type__c.toUpperCase()); } - private fflib_SharingMode getSharingModeFromString(String sharingMode) - { - switch on sharingMode.toUpperCase() - { - when 'WITH SHARING' - { - return fflib_SharingMode.WithSharing; - } - when 'WITHOUT SHARING' - { - return fflib_SharingMode.WithoutSharing; - } - when 'INHERITED SHARING' - { - return fflib_SharingMode.WithoutSharing; - } - when 'NONE' - { - return null; - } - } - return null; - } - private Type getSystemType(fflib_AppBinding__mdt binding, Schema.SObjectField sObjectField) { String systemTypeName = String.valueOf(binding.get(sObjectField)); diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingResolver.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingResolver.cls index 406617b..875c376 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingResolver.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingResolver.cls @@ -120,12 +120,6 @@ public virtual class fflib_AppBindingResolver return this; } - public fflib_IAppBindingResolver bySharingMode(fflib_SharingMode sharingMode) - { - this.bindingToResolve.setSharingMode(sharingMode); - return this; - } - public fflib_IAppBindingResolver byNamespacePrefix(String namespacePrefix) { this.bindingToResolve.setNamespacePrefix(namespacePrefix); diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingsSelector.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingsSelector.cls index 05d268d..60d9ba5 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingsSelector.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingsSelector.cls @@ -46,7 +46,6 @@ public virtual without sharing class fflib_AppBindingsSelector extends fflib_SOb fflib_AppBinding__mdt.NamespacePrefix, fflib_AppBinding__mdt.ImplementationType__c, fflib_AppBinding__mdt.InterfaceType__c, - fflib_AppBinding__mdt.SharingMode__c, fflib_AppBinding__mdt.Type__c }; } diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicSelectorFactory.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicSelectorFactory.cls index 65eec43..9719207 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicSelectorFactory.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicSelectorFactory.cls @@ -94,12 +94,6 @@ public virtual class fflib_DynamicSelectorFactory this.selectorFactory.setMock(sObjectType, selectorInstance); } - public fflib_DynamicSelectorFactory setSharingMode(fflib_SharingMode sharingMode) - { - this.sharingMode = sharingMode; - return this; - } - private void loadBindings() { fflib_IAppBindings appBindings = new fflib_AppBindings(resolver.resolve()); diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicServiceFactory.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicServiceFactory.cls index a0808a8..017c73a 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicServiceFactory.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicServiceFactory.cls @@ -66,12 +66,6 @@ public virtual class fflib_DynamicServiceFactory this.serviceFactory.setMock(serviceInterfaceType, serviceImpl); } - public fflib_DynamicServiceFactory setSharingMode(fflib_SharingMode sharingMode) - { - this.sharingMode = sharingMode; - return this; - } - private void loadBindings() { fflib_IAppBindings appBindings = new fflib_AppBindings(resolver.resolve()); diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBinding.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBinding.cls index 29d6c26..826641c 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBinding.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBinding.cls @@ -66,13 +66,6 @@ public interface fflib_IAppBinding */ Decimal getSequence(); - /** - * @return Returns an enum value fflib_SharingMode that defines the type of sharing used in the implementation class - * - * @see fflib_SharingMode - */ - fflib_SharingMode getSharingMode(); - /** * Creates a new instance of the implementation for this binding. * @@ -148,15 +141,4 @@ public interface fflib_IAppBinding * @return An instance of itself to enable method chaining */ fflib_IAppBinding setSequence(Decimal sequence); - - /** - * Sets an enum value fflib_SharingMode that defines the type of sharing used in the implementation class - * - * @param sharingMode A enum value of fflib_SharingMode representing the sharing mode - * - * @return An instance of itself to enable method chaining - * - * @see fflib_SharingMode - */ - fflib_IAppBinding setSharingMode(fflib_SharingMode sharingMode); } \ No newline at end of file diff --git a/sfdx-source/apex-extensions/main/application/dynamic/layouts/fflib_AppBinding__mdt-Binding Layout.layout-meta.xml b/sfdx-source/apex-extensions/main/application/dynamic/layouts/fflib_AppBinding__mdt-Binding Layout.layout-meta.xml index e20ce5c..717f47f 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/layouts/fflib_AppBinding__mdt-Binding Layout.layout-meta.xml +++ b/sfdx-source/apex-extensions/main/application/dynamic/layouts/fflib_AppBinding__mdt-Binding Layout.layout-meta.xml @@ -63,10 +63,6 @@ Required ImplementationType__c - - Required - SharingMode__c - diff --git a/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicDomainFactoryTest.cls b/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicDomainFactoryTest.cls index 9e7de58..1f1e055 100644 --- a/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicDomainFactoryTest.cls +++ b/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicDomainFactoryTest.cls @@ -179,8 +179,7 @@ public class fflib_DynamicDomainFactoryTest Type__c = 'Domain', BindingObject__c = '', BindingObjectAlternate__c = ACCOUNT_OBJECT_TYPE.getDescribe().getName(), - ImplementationType__c = MyDomainConstructor.class.getName(), - SharingMode__c = 'None' + ImplementationType__c = MyDomainConstructor.class.getName() ), new fflib_AppBinding__mdt( ApplicationPackage__c = otherApp.Id, @@ -188,8 +187,7 @@ public class fflib_DynamicDomainFactoryTest Type__c = 'Domain', BindingObject__c = '', BindingObjectAlternate__c = ACCOUNT_OBJECT_TYPE.getDescribe().getName(), - ImplementationType__c = OtherDomainConstructor.class.getName(), - SharingMode__c = 'None' + ImplementationType__c = OtherDomainConstructor.class.getName() ) }; } diff --git a/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicSelectorFactoryTest.cls b/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicSelectorFactoryTest.cls index 4146781..cecf5d3 100644 --- a/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicSelectorFactoryTest.cls +++ b/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicSelectorFactoryTest.cls @@ -37,8 +37,7 @@ public class fflib_DynamicSelectorFactoryTest @TestVisible private static final fflib_DynamicSelectorFactory Selector = - new fflib_DynamicSelectorFactory(bindingResolver) - .setSharingMode(fflib_SharingMode.WithSharing); + new fflib_DynamicSelectorFactory(bindingResolver); private static final Type MY_SELECTOR_TYPE = fflib_DynamicSelectorFactoryTest.MySelector.class; @@ -147,8 +146,7 @@ public class fflib_DynamicSelectorFactoryTest Type__c = 'Selector', BindingObject__c = '', BindingObjectAlternate__c = Schema.Account.SObjectType.getDescribe().getName(), - ImplementationType__c = MY_SELECTOR_TYPE.getName(), - SharingMode__c = 'With Sharing' + ImplementationType__c = MY_SELECTOR_TYPE.getName() ) }; } diff --git a/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicServiceFactoryTest.cls b/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicServiceFactoryTest.cls index 3c50250..8d2b587 100644 --- a/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicServiceFactoryTest.cls +++ b/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicServiceFactoryTest.cls @@ -112,7 +112,6 @@ public class fflib_DynamicServiceFactoryTest result.setBindingType(fflib_AppBindingType.Service); result.setInterfaceType(MY_SERVICE_TYPE); result.setImplementationType(MY_SERVICE_TYPE); - result.setSharingMode(fflib_SharingMode.WithSharing); result.setSequence(2); return result; } @@ -148,14 +147,12 @@ public class fflib_DynamicServiceFactoryTest Type__c = 'Service', InterfaceType__c = MY_SERVICE_INTERFACE_TYPE.getName(), ImplementationType__c = MY_SERVICE_TYPE.getName(), - SharingMode__c = 'With Sharing', BindingSequence__c = 1 ), new fflib_AppBinding__mdt( Type__c = 'Service', InterfaceType__c = MY_SERVICE_INTERFACE_TYPE.getName(), ImplementationType__c = MY_ALT_SERVICE_TYPE.getName(), - SharingMode__c = 'With Sharing', BindingSequence__c = 2 ) }; @@ -172,14 +169,12 @@ public class fflib_DynamicServiceFactoryTest Type__c = 'Service', InterfaceType__c = MY_SERVICE_INTERFACE_TYPE.getName(), ImplementationType__c = MY_SERVICE_TYPE.getName(), - SharingMode__c = 'With Sharing', BindingSequence__c = 2 ), new fflib_AppBinding__mdt( Type__c = 'Service', InterfaceType__c = MY_SERVICE_INTERFACE_TYPE.getName(), ImplementationType__c = MY_ALT_SERVICE_TYPE.getName(), - SharingMode__c = 'With Sharing', BindingSequence__c = 1 ) }; From d114fecf4f0467980e54d9fe44df11c996ba019d Mon Sep 17 00:00:00 2001 From: Wim Velzeboer Date: Mon, 11 Sep 2023 17:19:36 +0100 Subject: [PATCH 3/3] Remove Sharing Mode from Dynamic Application Factories Sharing mode is no longer required as SOQL queries can now run in USER_MODE or SYSTEM_MODE. --- .../classes/fflib_AppBindingResolver.cls | 1 - .../dynamic/classes/fflib_AppBindings.cls | 14 -------- .../classes/fflib_DynamicAppFactory.cls | 12 ------- .../classes/fflib_DynamicSelectorFactory.cls | 1 - .../dynamic/classes/fflib_SharingMode.cls | 34 ------------------- .../classes/fflib_SharingMode.cls-meta.xml | 5 --- .../interfaces/fflib_IAppBindingResolver.cls | 1 - .../classes/interfaces/fflib_IAppBindings.cls | 1 - .../fflib_DynamicServiceFactoryTest.cls | 3 +- 9 files changed, 1 insertion(+), 71 deletions(-) delete mode 100644 sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_SharingMode.cls delete mode 100644 sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_SharingMode.cls-meta.xml diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingResolver.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingResolver.cls index 875c376..7f65040 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingResolver.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingResolver.cls @@ -160,7 +160,6 @@ public virtual class fflib_AppBindingResolver .selectByType(bindingToResolve.getBindingType()) .selectByInterfaceType(bindingToResolve.getInterfaceType()) .selectByObject(bindingToResolve.getBindingObject()) - .selectBySharingMode(bindingToResolve.getSharingMode()) .selectBySequence(bindingToResolve.getSequence()); this.bindingToResolve = internalBindings.newAppBinding(); diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindings.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindings.cls index 7ff4053..06e95e4 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindings.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindings.cls @@ -182,20 +182,6 @@ public virtual class fflib_AppBindings return new fflib_AppBindings(result); } - public fflib_IAppBindings selectBySharingMode(fflib_SharingMode sharingMode) - { - if (null == sharingMode) return this; - - List result = new List(); - for (fflib_IAppBinding binding : bindings) - { - if (binding.getSharingMode() != sharingMode) continue; - - result.add(binding); - } - return new fflib_AppBindings(result); - } - public fflib_IAppBindings selectByNamespacePrefix(String namespacePrefix) { if (null == namespacePrefix) return this; diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicAppFactory.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicAppFactory.cls index 863966e..7f7f742 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicAppFactory.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicAppFactory.cls @@ -32,18 +32,6 @@ public abstract class fflib_DynamicAppFactory { protected String packageName; - protected fflib_SharingMode sharingMode - { - get - { - if (sharingMode == null) - { - sharingMode = fflib_SharingMode.WithSharing; - } - return sharingMode; - } - set; - } protected fflib_IAppBindingResolver resolver; protected Map routes; diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicSelectorFactory.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicSelectorFactory.cls index 9719207..f4b898c 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicSelectorFactory.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicSelectorFactory.cls @@ -106,7 +106,6 @@ public virtual class fflib_DynamicSelectorFactory Map implementationBySObjectType = appBindings.selectByType(fflib_AppBindingType.Selector) - .selectBySharingMode(this.sharingMode) .getImplementationBySObjectType(); this.selectorFactory = new fflib_ClassicSelectorFactory(implementationBySObjectType); diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_SharingMode.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_SharingMode.cls deleted file mode 100644 index 451877d..0000000 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_SharingMode.cls +++ /dev/null @@ -1,34 +0,0 @@ -/** - * File Name: fflib_SharingMode - * @description Enum with the Application Binding Sharing Modes - - * @author architect ir. Wilhelmus G.J. Velzeboer - * - * Copyright (c), W.G.J. Velzeboer, - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without modification, - * are permitted provided that the following conditions are met: - * - * - Redistributions of source code must retain the above author notice, - * this list of conditions and the following disclaimer. - * - Redistributions in binary form must reproduce the above copyright notice, - * this list of conditions and the following disclaimer in the documentation - * and/or other materials provided with the distribution. - * - Neither the name of the author nor the names of its contributors - * may be used to endorse or promote products derived from this software without - * specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES - * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL - * THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, - * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY - * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) - * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - */ -public enum fflib_SharingMode -{ - WithSharing, WithoutSharing, InheritedSharing, None -} \ No newline at end of file diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_SharingMode.cls-meta.xml b/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_SharingMode.cls-meta.xml deleted file mode 100644 index 754ecb1..0000000 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_SharingMode.cls-meta.xml +++ /dev/null @@ -1,5 +0,0 @@ - - - 57.0 - Active - diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBindingResolver.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBindingResolver.cls index 187f443..3748dcc 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBindingResolver.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBindingResolver.cls @@ -35,7 +35,6 @@ public interface fflib_IAppBindingResolver fflib_IAppBindingResolver bySequence(Integer sequence); fflib_IAppBindingResolver byType(fflib_AppBindingType bindingType); fflib_IAppBindingResolver byInterfaceType(System.Type interfaceType); - fflib_IAppBindingResolver bySharingMode(fflib_SharingMode sharingMode); fflib_IAppBindingResolver byNamespacePrefix(String namespacePrefix); fflib_IAppBindingResolver byPackageName(String packageName); List resolve(); diff --git a/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBindings.cls b/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBindings.cls index edce326..2710d9d 100644 --- a/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBindings.cls +++ b/sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBindings.cls @@ -44,7 +44,6 @@ public interface fflib_IAppBindings fflib_IAppBindings selectBySequence(Decimal sequence); fflib_IAppBindings selectByType(fflib_AppBindingType bindingType); fflib_IAppBindings selectByInterfaceType(System.Type interfaceType); - fflib_IAppBindings selectBySharingMode(fflib_SharingMode sharingMode); fflib_IAppBindings selectByNamespacePrefix(String namespacePrefix); fflib_IAppBindings selectByPackageName(String packageName); } \ No newline at end of file diff --git a/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicServiceFactoryTest.cls b/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicServiceFactoryTest.cls index 8d2b587..91ab26f 100644 --- a/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicServiceFactoryTest.cls +++ b/sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicServiceFactoryTest.cls @@ -128,8 +128,7 @@ public class fflib_DynamicServiceFactoryTest new fflib_AppBindingResolver(); private static final fflib_DynamicServiceFactory Service = - new fflib_DynamicServiceFactory(bindingResolver) - .setSharingMode(fflib_SharingMode.WithSharing); + new fflib_DynamicServiceFactory(bindingResolver); public interface IMyService {}