wim/fflib-apex-extensions
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove Sharing Mode from Dynamic Application Factories

Browse Source 
Sharing mode is no longer required as SOQL queries can now run in USER_MODE or SYSTEM_MODE.
This commit is contained in:
wim
2023-09-11 17:18:53 +01:00
parent 671cac07b3
commit 4390f83aef
12 changed files with 6 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicDomainFactoryTest.cls
+2 -4
View File
@@ -179,8 +179,7 @@ public class fflib_DynamicDomainFactoryTest
Type__c = 'Domain',
BindingObject__c = '',
BindingObjectAlternate__c = ACCOUNT_OBJECT_TYPE.getDescribe().getName(),
ImplementationType__c = MyDomainConstructor.class.getName(),
SharingMode__c = 'None'
ImplementationType__c = MyDomainConstructor.class.getName()
),
new fflib_AppBinding__mdt(
ApplicationPackage__c = otherApp.Id,
@@ -188,8 +187,7 @@ public class fflib_DynamicDomainFactoryTest
Type__c = 'Domain',
BindingObject__c = '',
BindingObjectAlternate__c = ACCOUNT_OBJECT_TYPE.getDescribe().getName(),
ImplementationType__c = OtherDomainConstructor.class.getName(),
SharingMode__c = 'None'
ImplementationType__c = OtherDomainConstructor.class.getName()
)
};
}
sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicSelectorFactoryTest.cls
+2 -4
View File
@@ -37,8 +37,7 @@ public class fflib_DynamicSelectorFactoryTest
@TestVisible
private static final fflib_DynamicSelectorFactory Selector =
new fflib_DynamicSelectorFactory(bindingResolver)
.setSharingMode(fflib_SharingMode.WithSharing);
new fflib_DynamicSelectorFactory(bindingResolver);
private static final Type MY_SELECTOR_TYPE = fflib_DynamicSelectorFactoryTest.MySelector.class;
@@ -147,8 +146,7 @@ public class fflib_DynamicSelectorFactoryTest
Type__c = 'Selector',
BindingObject__c = '',
BindingObjectAlternate__c = Schema.Account.SObjectType.getDescribe().getName(),
ImplementationType__c = MY_SELECTOR_TYPE.getName(),
SharingMode__c = 'With Sharing'
ImplementationType__c = MY_SELECTOR_TYPE.getName()
)
};
}
sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicServiceFactoryTest.cls
-5
View File
@@ -112,7 +112,6 @@ public class fflib_DynamicServiceFactoryTest
result.setBindingType(fflib_AppBindingType.Service);
result.setInterfaceType(MY_SERVICE_TYPE);
result.setImplementationType(MY_SERVICE_TYPE);
result.setSharingMode(fflib_SharingMode.WithSharing);
result.setSequence(2);
return result;
}
@@ -148,14 +147,12 @@ public class fflib_DynamicServiceFactoryTest
Type__c = 'Service',
InterfaceType__c = MY_SERVICE_INTERFACE_TYPE.getName(),
ImplementationType__c = MY_SERVICE_TYPE.getName(),
SharingMode__c = 'With Sharing',
BindingSequence__c = 1
),
new fflib_AppBinding__mdt(
Type__c = 'Service',
InterfaceType__c = MY_SERVICE_INTERFACE_TYPE.getName(),
ImplementationType__c = MY_ALT_SERVICE_TYPE.getName(),
SharingMode__c = 'With Sharing',
BindingSequence__c = 2
)
};
@@ -172,14 +169,12 @@ public class fflib_DynamicServiceFactoryTest
Type__c = 'Service',
InterfaceType__c = MY_SERVICE_INTERFACE_TYPE.getName(),
ImplementationType__c = MY_SERVICE_TYPE.getName(),
SharingMode__c = 'With Sharing',
BindingSequence__c = 2
),
new fflib_AppBinding__mdt(
Type__c = 'Service',
InterfaceType__c = MY_SERVICE_INTERFACE_TYPE.getName(),
ImplementationType__c = MY_ALT_SERVICE_TYPE.getName(),
SharingMode__c = 'With Sharing',
BindingSequence__c = 1
)
};