wim/fflib-apex-extensions
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Override getRecordsWithNotBlankFieldValues for non-String fields (#90)

Browse Source 
* Override getRecordsWithNotBlankFieldValues in fflib_SObjects2

The base fflib_SObjects implementation casts every value to String, which
throws a TypeException on Date/Datetime/Number/Lookup fields. This override
generalises the check to "any non-null value, and for Strings also non-blank"
so the helper works for every field type.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Update fflib_SObjects2.cls

Rename method to getRecordsWithNonBlankFieldValues

* Update fflib_SObjects2Test.cls

Rename method to getRecordsWithNonBlankFieldValues

* Update fflib_SObjects2.cls

Rename variable

Co-authored-by: Robin Weymans <robin.weymans@mylighthouse.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: William Velzeboer <6429417+wimvelzeboer@users.noreply.github.com>
This commit is contained in:
robinreditus
2026-08-05 09:23:06 +01:00
committed by GitHub
co-authored by Claude Opus 4.7 Robin Weymans William Velzeboer
parent 368978bf20
commit 94129a9791
3 changed files with 71 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sfdx-source/apex-extensions/tests/classes/domains/fflib_SObjects2Test.cls
+39 -1
View File
@@ -679,6 +679,30 @@ private class fflib_SObjects2Test
System.Assert.areEqual(3, domain.selectWithShippingCountry().size());
}
@IsTest
static void itShouldReturnRecordsWithNonNullNumericField()
{
DomainAccounts domain = generateDomain();
System.Assert.areEqual(4, domain.selectWithAnnualRevenue().size());
}
@IsTest
static void itShouldReturnRecordsWithNonNullDatetimeField()
{
Datetime now = Datetime.now();
DomainAccounts domain = new DomainAccounts(
new List<Account>
{
(Account) fflib_MockSObjectUtil.addFieldValue(new Account(Name = 'A'), Account.CreatedDate, now),
(Account) fflib_MockSObjectUtil.addFieldValue(new Account(Name = 'B'), Account.CreatedDate, now),
new Account(Name = 'C')
}
);
System.Assert.areEqual(2, domain.selectWithCreatedDate().size());
}
@IsTest
static void itShouldReturnRecordsWithAllFieldValues()
{
@@ -845,11 +869,25 @@ private class fflib_SObjects2Test
public List<Account> selectWithShippingCountry()
{
return getRecordsWithNotBlankFieldValues(
return getRecordsWithNonBlankFieldValues(
Schema.Account.ShippingCountry
);
}
public List<Account> selectWithAnnualRevenue()
{
return getRecordsWithNonBlankFieldValues(
Schema.Account.AnnualRevenue
);
}
public List<Account> selectWithCreatedDate()
{
return getRecordsWithNonBlankFieldValues(
Schema.Account.CreatedDate
);
}
public List<Account> selectWithEmptyRecord()
{
return getRecordsWithAllBlankFieldValues(