Remove Sharing Mode from Dynamic Application Factories

Sharing mode is no longer required as SOQL queries can now run in USER_MODE or SYSTEM_MODE.

sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindingResolver.cls

@@ -160,7 +160,6 @@ public virtual class fflib_AppBindingResolver
 						.selectByType(bindingToResolve.getBindingType())
 						.selectByInterfaceType(bindingToResolve.getInterfaceType())
 						.selectByObject(bindingToResolve.getBindingObject())
-						.selectBySharingMode(bindingToResolve.getSharingMode())
 						.selectBySequence(bindingToResolve.getSequence());
 
 		this.bindingToResolve = internalBindings.newAppBinding();

sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_AppBindings.cls

@@ -182,20 +182,6 @@ public virtual class fflib_AppBindings
 		return new fflib_AppBindings(result);
 	}
 
-	public fflib_IAppBindings selectBySharingMode(fflib_SharingMode sharingMode)
-	{
-		if (null == sharingMode) return this;
-
-		List<fflib_IAppBinding> result = new List<fflib_IAppBinding>();
-		for (fflib_IAppBinding binding : bindings)
-		{
-			if (binding.getSharingMode() != sharingMode) continue;
-
-			result.add(binding);
-		}
-		return new fflib_AppBindings(result);
-	}
-
 	public fflib_IAppBindings selectByNamespacePrefix(String namespacePrefix)
 	{
 		if (null == namespacePrefix) return this;

sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicAppFactory.cls

@@ -32,18 +32,6 @@ public abstract class fflib_DynamicAppFactory
 {
 	protected String packageName;
 
-	protected fflib_SharingMode sharingMode
-	{
-		get
-		{
-			if (sharingMode == null)
-			{
-				sharingMode = fflib_SharingMode.WithSharing;
-			}
-			return sharingMode;
-		}
-		set;
-	}
 	protected fflib_IAppBindingResolver resolver;
 	protected Map<System.Type, System.Type> routes;
 

sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_DynamicSelectorFactory.cls

@@ -106,7 +106,6 @@ public virtual class fflib_DynamicSelectorFactory
 
 		Map<SObjectType, Type> implementationBySObjectType =
 				appBindings.selectByType(fflib_AppBindingType.Selector)
-						.selectBySharingMode(this.sharingMode)
 						.getImplementationBySObjectType();
 
 		this.selectorFactory = new fflib_ClassicSelectorFactory(implementationBySObjectType);

sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_SharingMode.cls

@@ -1,34 +0,0 @@
-/**
- * File Name: fflib_SharingMode 
- * @description Enum with the Application Binding Sharing Modes
-
- * @author architect ir. Wilhelmus G.J. Velzeboer
- *
- * Copyright (c), W.G.J. Velzeboer,
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
- *   are permitted provided that the following conditions are met:
- *
- * - Redistributions of source code must retain the above author notice,
- *      this list of conditions and the following disclaimer.
- * - Redistributions in binary form must reproduce the above copyright notice,
- *      this list of conditions and the following disclaimer in the documentation
- *      and/or other materials provided with the distribution.
- * - Neither the name of the author nor the names of its contributors
- *      may be used to endorse or promote products derived from this software without
- *      specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
- * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL
- * THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-public enum fflib_SharingMode
-{
-	WithSharing, WithoutSharing, InheritedSharing, None
-}

sfdx-source/apex-extensions/main/application/dynamic/classes/fflib_SharingMode.cls-meta.xml

@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
-    <apiVersion>57.0</apiVersion>
-    <status>Active</status>
-</ApexClass>

sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBindingResolver.cls

@@ -35,7 +35,6 @@ public interface fflib_IAppBindingResolver
 	fflib_IAppBindingResolver bySequence(Integer sequence);
 	fflib_IAppBindingResolver byType(fflib_AppBindingType bindingType);
 	fflib_IAppBindingResolver byInterfaceType(System.Type interfaceType);
-	fflib_IAppBindingResolver bySharingMode(fflib_SharingMode sharingMode);
 	fflib_IAppBindingResolver byNamespacePrefix(String namespacePrefix);
 	fflib_IAppBindingResolver byPackageName(String packageName);
 	List<fflib_IAppBinding> resolve();

sfdx-source/apex-extensions/main/application/dynamic/classes/interfaces/fflib_IAppBindings.cls

@@ -44,7 +44,6 @@ public interface fflib_IAppBindings
 	fflib_IAppBindings selectBySequence(Decimal sequence);
 	fflib_IAppBindings selectByType(fflib_AppBindingType bindingType);
 	fflib_IAppBindings selectByInterfaceType(System.Type interfaceType);
-	fflib_IAppBindings selectBySharingMode(fflib_SharingMode sharingMode);
 	fflib_IAppBindings selectByNamespacePrefix(String namespacePrefix);
 	fflib_IAppBindings selectByPackageName(String packageName);
 }

sfdx-source/apex-extensions/tests/classes/application/fflib_DynamicServiceFactoryTest.cls

@@ -128,8 +128,7 @@ public class fflib_DynamicServiceFactoryTest
             new fflib_AppBindingResolver();
 
     private static final fflib_DynamicServiceFactory Service =
-            new fflib_DynamicServiceFactory(bindingResolver)
+            new fflib_DynamicServiceFactory(bindingResolver);
-                    .setSharingMode(fflib_SharingMode.WithSharing);
 
     public interface IMyService {}